coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 328
- 20 of 21 (95.24%) changed or added relevant lines in 7 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.07%) to 95.387%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/Infrastructure/User/Auth/Auth.php | 7 | 8 | 87.5% | ||
| <!-- | Total: | 20 | 21 | 95.24% | --> |
| Totals | |
|---|---|
| Change from base Build 307: | 0.07% |
| Covered Lines: | 517 |
| Relevant Lines: | 542 |
I made some mistakes in the past. Read Model and projections should be in Infra as are representations of the Entities and not Domain specific responsibility.
Still thining about how to deal with Sessions, ATM I've a SessionInterface in domain but looks strange there. Will try to sort this in another PR.