jorge07 / symfony-6-es-cqrs-boilerplate

Symfony 6 DDD ES CQRS backend boilerplate.
MIT License
1.07k stars 187 forks source link

Full potential of PHP 7.4 part one #146

Closed cv65kr closed 4 years ago

cv65kr commented 4 years ago

This is a first part changes to fully use PHP 7.4 potential. Contains changes which not generate Typed property must not be accessed before initialization. For other classes refactoring will be needed to works properly because broadway.

karael commented 4 years ago

the war begin, psalm vs phpstan 🤔

I don't think it's a good idea to add annotation because of one tool

jorge07 commented 4 years ago

Language has his limitations I think Psalm add value in this are and at the end it's a convention comment like @internal and others like this. With the benefit of maintain less code. Less code is always better. Less code makes me happy

LGTM :+1: