FIX: added casting number of pages and limit query for GetEvents

jorge07 / symfony-6-es-cqrs-boilerplate

Symfony 6 DDD ES CQRS backend boilerplate.

MIT License

1.07k stars 187 forks source link

FIX: added casting number of pages and limit query for GetEvents #50

Closed patrykwozinski closed 6 years ago

patrykwozinski commented 6 years ago

Added query parameter for GetEvents action to fetch only one record. It coverage additional method in tests and shoved me an exception in building GetEventsQuery. The problem occurred when $request->get('limit', 1) gives me string not default integer value. :)

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 103

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 95.503%

Totals
Change from base Build 100:	0.4%
Covered Lines:	446
Relevant Lines:	467

💛 - Coveralls

jorge07 commented 6 years ago

Needs rebase but LGTM

patrykwozinski commented 6 years ago

Rebased and ready to merge. :) Thank you guys.

jorge07 commented 6 years ago

I fixed the pagination issue in #52. Seems you'll need to rebase and resolve an small conflict. All good a part of that.

Thanks a lot for your contributions @patrykwozinski and @Lutacon, much appreciated.

jorge07 commented 6 years ago

I added the fix in #59 so I'll close this one. @patrykwozinski thanks a lot for your contribution ;)