search

jorge3fernandes / City_of_Brockton_R

This repo documents the impact of data science in city through the use of police dispatch log.
https://jorgefernandes.shinyapps.io/Brockton_Police_Dispatch/
2 stars 1 forks source link

Add some unit tests #12

Open sconde opened 6 years ago

sconde commented 6 years ago

@jorge3fernandes I've added Travis CI on my personal of this project. Along with the updated functions, I've added a single unite test to each and also added a .travis.yml which build a Rcpp on travis to run those test.

This method has been deprecated, although it's still working. In the near future I need to move to the travis R build that is at its infancy.

sconde commented 6 years ago

@jorge3fernandes Since there are 2 unit tests, do you think we can close this issue or should we wait until we have more experiences?

jorge3fernandes commented 6 years ago

I'm making some changes that will force us to change our testing criteria. Let's wait until we merge my changes

jorge3fernandes commented 6 years ago

Hey @sconde , since the code doesn't download anything, we need to change the testing criteria. Lets discuss when we meet.

sconde commented 6 years ago

@jorge3fernandes Meet today?

jorge3fernandes commented 6 years ago

yes! we should do it around 8pm EST.