search

jorgealmerio / QEsg

QEsg - Sewer Network Design Plugin for Qgis
17 stars 3 forks source link

minimim covering #6

Closed trasto21 closed 4 years ago

trasto21 commented 5 years ago

i'm using your plugin and is wonderful. the only issue i found were impossible modify the minimim covering, even if i change the number in the settings mask

jorgealmerio commented 5 years ago

The minimum covering in the settings is the default value for covering. It's only used the first time you ask the plugin to fill in data with default values. The covering may be changed in the 'REC_MIN' attribute table field for each pipe reach (each record in the table).

trasto21 commented 5 years ago

ok, thanks, i have a solution as you told me. anyway, the slot in the setting mask don't change the coloumn in the pipes' database.

jorgealmerio commented 5 years ago

You are right, maybe the label "Default Minimum covering (m)" would be more appropriated! I think it's NOT a good idea to change all the columns values from the "setting mask", because you can have particular covering already manual entered in the attribute table. What do you think?

trasto21 commented 5 years ago

the value in the setting mask don't update the coloumn and should be a good first step for the implementation of that coloumn. then you can change every value in the database for the particular covering manual entered

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Mail priva di virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Il giorno lun 8 lug 2019 alle ore 22:07 jorgealmerio < notifications@github.com> ha scritto:

You are right, maybe the label "Default Minimum covering (m)" would be more appropriated! I think it's NOT a good idea to change all the columns values from the "setting mask", because you can have particular covering already manual entered in the attribute table. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jorgealmerio/QEsg/issues/6?email_source=notifications&email_token=AMRZWEMXDYF3MT4G6YU4JKTP6OM6JA5CNFSM4H634O4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOGN4Y#issuecomment-509372147, or mute the thread https://github.com/notifications/unsubscribe-auth/AMRZWEOAF37RGYQ57CX4HE3P6OM6JANCNFSM4H634O4A .

jorgealmerio commented 5 years ago

No, you are wrong! If you have 'REC_MIN' Column with Null values (First time) and use the '04 Fill Fields' button command, so the column will be filled in with the 'setting mask'!

I think I will put a button beside the setting mask to overwrite the column.