search

jorgearanda / fish

A fish banks simulator to conduct environmental psychology studies
MIT License
5 stars 5 forks source link

Updated fish scss file with new colour scheme. #183

Closed James-Firth closed 9 years ago

James-Firth commented 9 years ago

I added some background/font colours so the participant UI is all the proper shades of blue/green.

Also should we be including the *.css.map files? They don't seem to be in the gitignore file and I'm not sure what the best practice is regarding them. Closes #160

normful commented 9 years ago

I usually don't track the generated CSS sourcemap files in git, but some people do. This page does a good job explaining how they can be useful: https://developer.chrome.com/devtools/docs/css-preprocessors

James-Firth commented 9 years ago

Great thanks for the info Norm, I'll give it a read.

I'm fine tracking it or not, though I think I'd probably prefer not to since it's just a blob of data that'll get re-made if someone changes the stylesheet anyways (if I understand correctly). I just included them this time so we could discuss it.

If we decide not to we should make sure it's in the .gitignore file though.

I'll wait and see if @jorgearanda has an opinion on it.

jorgearanda commented 9 years ago

Cool, thanks!

The only thing I don't like about not tracking the css files is that it adds a non-npm dependency for deploying fish (ruby and the sass gem), but we've already declared those as dependencies so it should be fine.

I'll just merge this and we can add the css to the gitignore file on a later commit.

James-Firth commented 9 years ago

@jorgearanda I think we could still track the .css to avoid that. But there's also a .css.map file, just not sure if we need that too