search

jorgearanda / fish

A fish banks simulator to conduct environmental psychology studies
MIT License
5 stars 5 forks source link

Running and finished simulations are now reported to experimenters #192

Closed btruhand closed 9 years ago

btruhand commented 9 years ago

Tell me if there's anything amiss Jorge. I know the UI's not great

jorgearanda commented 9 years ago

Thanks Btara, and sorry for the delay. I'll take a look at this pr tomorrow.

jorgearanda commented 9 years ago

Nice job, Btara. Besides the naming problems, the other thing I'd like you to polish a bit is the UI--to make it consistent with the style in the rest of the page. Thanks!

btruhand commented 9 years ago

Hi Jorge, sorry I missed the meeting. I was extremely fatigued from yesterday. About the UI, what do you think needs to be added/removed in particular so I have a grasp of what I need to do

jorgearanda commented 9 years ago

No worries, Btara. For the UI, try using the widgets that Bootstrap uses if you're not already, and perhaps try a table format like the rest of the tables in that page.

btruhand commented 9 years ago

So instead of making it a scrolling list you want me to make it into a table format? Would you want me then to let the table just continually grow, or do you want me to put a limit to the number of items shown there?

jorgearanda commented 9 years ago

Letting it continually grow is fine by now :-)

btruhand commented 9 years ago

Jorge, right now I have the information layed out side by side, one for running and finishing simulations the other planned to be for interrupted simulations. Do you want them to stay the same or have them be separated sections?

jorgearanda commented 9 years ago

I like the way it looks and does not clutter when it's side by side.

btruhand commented 9 years ago

I've made the changes Jorge and this PR also solves issue #144 . Also I've opened a new issue #201

jorgearanda commented 9 years ago

Great, thanks!