Closed btruhand closed 7 years ago
Thanks for this PR again, @btruhand !
I have a question: we have as prerequisites ruby and sass. I don't see them included here, but maybe I'm missing something?
Ah @jorgearanda about the Ruby and Sass, I didn't really think of putting it in the docker since I was thinking of providing the docker as a runtime container not necessarily a build container also. Would you like me to add in a build container for Ruby and Sass?
My knowledge of docker is still pretty limited—but what I was picturing was that the container would have all that is needed to run fish
on a fresh box. Maybe that's a "build container"? If so, then yes, I think ruby and sass should be there as they are requisites (along with mongo)
That would constitute both a build and a runtime container I think. In my own understanding a build container is one used to build the dependencies and the runtime container is responsible to run it (assuming the dependencies are there already)
I'll make a diagram and put it into the README
so it'll be clearer the structure of the current Docker setup.
P.S Sorry for just replying, been quite busy myself. Will try to work on it this weekend :)
You're awesome ;)
Hi @jorgearanda I made the changes and also noticed I should add a few things too (like populate DB command for Dockered mongo, tell me if you want the other DB related scripts too for the Docker version)
You can check out the diagram and explanation I gave
Dockerization of FISH