search

jorgebastida / gordon

λ Gordon is a tool to create, wire and deploy AWS Lambdas using CloudFormation
Other
2.05k stars 137 forks source link

gordon appears to ignore npm failures #155

Closed ericblade closed 6 years ago

ericblade commented 6 years ago

Caveat: This is not occurring to me, but to someone else on my team, and I don't have direct access to the machine to see what is going on. Even if I did, I don't know exactly what I'd look at to see what is failing and how.

Have a machine where doing a gordon build is failing to build zip files that contain the npm modules. It looks like 'npm install' is failing on them, for some reason. What that is, I don't know -- when we use the same machine and 'npm install' in the module, then it works.

So, gordon is actually uploading the resulting bad zip files that are missing the modules, with no errors.

We are using 'gordon build && gordon apply' . . . so perhaps build is not throwing an error, or build is just completely ignoring the error.

ericblade commented 6 years ago

my mistake, the repository was missing it's package.json and other machines had it locally