search

jorgebastida / gordon

λ Gordon is a tool to create, wire and deploy AWS Lambdas using CloudFormation
Other
2.04k stars 137 forks source link

Add API Gateway IntegrationResponse header support #70

Closed elkelk closed 7 years ago

elkelk commented 8 years ago

This adds support for static and dynamic IntegrationResponse headers as specified here: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apitgateway-method-integration-integrationresponse.html

The PR includes a CORS example and documentation for parameters within the Integration Response section.

I dug into the tests a bit, but didn't see an easy way to insert coverage. I'd love any direction/suggestions for adding test coverage.

https://github.com/jorgebastida/gordon/issues/68

avengerpenguin commented 8 years ago

+1 for this for me. Is there anything I can do to help get it in?

ahl commented 8 years ago

another +1 from me: I ended up implementing the same thing (here: https://github.com/jorgebastida/gordon/pull/107), not realizing that this work had already been done. It would be great to see this accepted.

micahwedemeyer commented 8 years ago

👍 CORS support is super important for a huge percentage of projects that would use Lambda.

DaRizat commented 7 years ago

+1 Any update on when this might be available?

YoavGivati commented 7 years ago

+1. Would help a lot with new engineers not having to install from the src just to use this critical fix.

Starting to get concerned that it's been over 3 months since the last PR was merged in.

cc @jorgebastida

jorgebastida commented 7 years ago

Sorry for the long delay! This looks amazing :) Thank you all for you patience