search

jorgebg / redmine-openid-selector

Redmine plugin. Provides an OpenID selector at login.
http://projects.jorgebg.com/projects/redmine-openid-selector
23 stars 13 forks source link

Fixed Issue #89 from your Redmine Issues list #2

Closed amildahl closed 13 years ago

amildahl commented 13 years ago

Just a case of having an extra slash. I haven't tested this where redmine was not installed in the root though.

My URL is http://projects.drewdahl.com/ and that's where redmine is at.

Issue #89 => http://projects.jorgebg.com/issues/89

amildahl commented 13 years ago

Just thought I'd make mention that the extra slash was coming from here:

app/helpers/account_helper.rb:4 - "#{Redmine::Utils.relative_url_root}/"

app/views/account/_view_account_login_bottom.html.erb:7 openid.img_path = "<%= relative_root %>/plugin_assets/redmine-openid-selector/javascripts/openid-selector/images/";

As can be seen, <%= relative_root %> returns with a slash and an extra slash is added after that. I think this would work fine if redmine wasn't in the root (again, untested), but it doesn't work when redmine is in root.

jorgebg commented 13 years ago

Great! Sorry for the delay, thank you very much for your contribution!