search

jorgebg / redmine-openid-selector

Redmine plugin. Provides an OpenID selector at login.
http://projects.jorgebg.com/projects/redmine-openid-selector
23 stars 13 forks source link

Problem with at least some versions of IE. Patch attached. #3

Closed kubitron closed 12 years ago

kubitron commented 13 years ago

Turns out that the current version of this plugin seems to have problems with Internet Explorer. The issue is that IE (or at least some versions) do not like attempts to set the innerHTML on tags. Consequently, the "openid_input_area" causes IE to fail. A patch to app/views/account/_view_account_login_bottom.html.erb is as follows:

diff --git a/vendor/plugins/redmine-openid-selector/app/views/account/_view_account_login_bottom.html.erb b/vendor/plugins/redmine-openid-selector/app/views/account/_view_acco
index 4f42a3d..f67eba4 100644
--- a/vendor/plugins/redmine-openid-selector/app/views/account/_view_account_login_bottom.html.erb
+++ b/vendor/plugins/redmine-openid-selector/app/views/account/_view_account_login_bottom.html.erb
@@ -16,6 +16,6 @@
                        <tbody id="openid_choice"> 
                        <tr>    <td>Please click your account provider:</td> </tr>
                        <tr>    <td id="openid_btns"></td> </tr>
-                       <tr id="openid_input_area"><td></td></tr>
+                       <tr><td id="openid_input_area"></td></tr>
                        </tbody>
                </table>

This change leaves a bit of extra space at the bottom of the input box when the openid_input_area is hidden. Perhaps some hacking with CSS could help, but at least this now works with IE.

jorgebg commented 12 years ago

patched :) thank you!

https://github.com/jorgebg/redmine-openid-selector/commit/2929e9b47ee9277be7017593853a1fc0bdbc334b

kubitron commented 12 years ago

Glad to help.