search

jorgebucaran / classcat

Build a class attribute string quickly
MIT License
905 stars 22 forks source link

Fixes bug where child elements all being false still includes object key in className #14

Closed developerdizzle closed 6 years ago

developerdizzle commented 6 years ago

Fixes https://github.com/JorgeBucaran/classcat/issues/13

Also refactors/simplifies the logic to force space (" ") to be the separator, and no longer use prefix as both separator and prefix. This breaks the original "prefix" test, which I've updated to reflect the new functionality. Because this is a breaking change, a major version bump is required.

codecov-io commented 6 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          13     15    +2     
  Branches        6      9    +3     
=====================================
+ Hits           13     15    +2
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3097158...2a43e59. Read the comment docs.