Default exports break down in converted CJS version

jorgebucaran / colorette

🌈Easily set your terminal text color & styles

MIT License

1.61k stars 51 forks source link

Default exports break down in converted CJS version #75

Closed kibertoad closed 3 years ago

kibertoad commented 3 years ago

See https://github.com/pinojs/pino-pretty/issues/237

process["default"].env is definitely incorrect. Looks like we should avoid using default imports here.

kibertoad commented 3 years ago

@jorgebucaran Wonder if we could be running CI on built CJS version somehow.

kibertoad commented 3 years ago

Duplicate of #73

jorgebucaran commented 3 years ago

Should be possible, let me check the docs.

jorgebucaran commented 3 years ago

@kibertoad Sorry, looking into your comment again, I'm not sure exactly what you mean. The CI runs the tests. We could look into adding a special test just for the CJS version, though. That what you were thinking?