Closed jorgebucaran closed 3 years ago
Merging #84 (57d4fad) into main (eba26cd) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 133 147 +14
=========================================
+ Hits 133 147 +14
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eba26cd...57d4fad. Read the comment docs.
Add mentions about inspiration to docs?
@jorgebucaran I think that's a good idea. Let's add a section dedicated to credits and honourable mentions.
That's a great idea. Done in 6a4a871! 💯
@jorgebucaran https://github.com/jorgebucaran/colorette/commit/6a4a871e5953e8538c2a606eb62b9c1d664ad284 will be better by adding explicit link to chalk
and picocolors
’s mention and link.
I'm pretty happy with the result, actually, but I'll definitely consider your suggestion. Thanks!
The acknowledgment sounds like it was my contribution to this project, which it wasn’t.
I don’t mind adopting performance tricks.
I would really appreciate if you could update this section with proper links to the projects. Would be even better if the section wasn’t buried somewhere down the page. Thanks
Sure, I can think of another way to acknowledge you. 👌
@alexeyraspopov We ended up listing reference in release notes next to a specific change, which seems more appropriate, since this is a one-off optimization and not something fundamental to how Colorette is built. Agreed on readme notes making it sound like it was contributed by you directly. Would you prefer us rephrasing, or removing it and just keeping release notes?
I’d prefer adding links to the projects, as I mentioned previously.
Yup, we are adding links for sure, give us a bit of time :)
Absolutely. Added in ada9fb377685c45e6cee6aa4acd636a9ab5fdf93. 👍
This improves runtime performance when clearing bleeding sequences, using
.substring()
rather than regexes.This clever idea is inspired by @alexeyraspopov's
replaceClose
function in picocolors. Thank you for that! 🙌