fisher command stuck after a few package updates

orefalo commented 5 years ago

it's weird...

when one of my pkg has an update, the regular fisher command will get stuck after a few pkg updates.

I need to open a new tab, which show a plain fish prompt, and issue the command again.

jorgebucaran commented 5 years ago

@orefalo

What is your OS, fish-shell version and Fisher version?
What's in your fishfile?
What's in your ~/.config/fish/config.fish file?

If you are using fisher 3.x: did you follow these instructions https://github.com/jorgebucaran/fisher/issues/450 when upgrading? Else what did you do?

Anything else you can share with us? Do you have any console output I could take a look at?

orefalo commented 5 years ago

osx, fish 3.0.0 installed via brew, fisher version 3.1.1

File: /Users/orefalo/.config/fish/config.fish
───────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ #set -g fish_user_paths "/usr/local/opt/node@8/bin" $fish_user_paths
   2   │
   3   │ if not functions -q fisher
   4   │     set -q XDG_CONFIG_HOME; or set XDG_CONFIG_HOME ~/.config
   5   │     curl https://git.io/fisher --create-dirs -sLo $XDG_CONFIG_HOME/fish/functions/fisher.fish
   6   │     fish -c fisher
   7   │ end
   8   │

➜ fisher ls
barnybug/docker-fish-completion
brgmnn/fish-docker-compose
danhper/fish-kubectl
jorgebucaran/fish-git-util
laughedelic/brew-completions
laughedelic/pisces
Markcial/cprintf
matchai/spacefish
oh-my-fish/plugin-fasd
oh-my-fish/plugin-ssh
oh-my-fish/plugin-wifi-password
orefalo/free
orefalo/g2
orefalo/grc
orefalo/javahome
orefalo/masterconfig
patrickf3139/Colored-Man-Pages

not sure if it's fisher or fish. But I get random locks up as well. like when I use git from the command line.

I will try to capture the fisher freeze up on video. it seems to happen when the pkg associated with the theme/prompt are updated.

jorgebucaran commented 5 years ago

@orefalo Thanks! I noticed no problems after installing the same packages and running fisher a few times. My system spec is essentially the same as yours. fisher took 6s~8s on average to run every time. I noticed matchai/spacefish's prompt is a bit slow (blame git?), but I wouldn't call it a random lockup. Your config.fish is essentially empty, so we know it's nothing to do with that either.

Maybe something it's already running in the background when you run fisher? If you are able to figure that out or narrow down the problem to something else, please reopen.

fetching https://codeload.github.com/barnybug/docker-fish-completion/tar.gz/master
fetching https://codeload.github.com/brgmnn/fish-docker-compose/tar.gz/master
fetching https://codeload.github.com/danhper/fish-kubectl/tar.gz/master
fetching https://codeload.github.com/jorgebucaran/fish-git-util/tar.gz/master
fetching https://codeload.github.com/laughedelic/brew-completions/tar.gz/master
fetching https://codeload.github.com/laughedelic/pisces/tar.gz/master
fetching https://codeload.github.com/Markcial/cprintf/tar.gz/master
fetching https://codeload.github.com/matchai/spacefish/tar.gz/master
fetching https://codeload.github.com/oh-my-fish/plugin-fasd/tar.gz/master
fetching https://codeload.github.com/oh-my-fish/plugin-ssh/tar.gz/master
fetching https://codeload.github.com/oh-my-fish/plugin-wifi-password/tar.gz/master
fetching https://codeload.github.com/orefalo/free/tar.gz/master
fetching https://codeload.github.com/orefalo/g2/tar.gz/master
fetching https://codeload.github.com/orefalo/grc/tar.gz/master
fetching https://codeload.github.com/orefalo/javahome/tar.gz/master
fetching https://codeload.github.com/orefalo/masterconfig/tar.gz/master
fetching https://codeload.github.com/patrickf3139/Colored-Man-Pages/tar.gz/master
linking ~/.config/fish/functions/docker-compose.fish
linking ~/.config/fish/functions/docker.fish
linking ~/.config/fish/completions/docker-compose.fish
linking ~/.config/fish/completions/kubectl.fish
linking ~/.config/fish/functions/git_ahead.fish
linking ~/.config/fish/functions/git_branch_name.fish
linking ~/.config/fish/functions/git_is_detached_head.fish
linking ~/.config/fish/functions/git_is_dirty.fish
linking ~/.config/fish/functions/git_is_empty.fish
linking ~/.config/fish/functions/git_is_repo.fish
linking ~/.config/fish/functions/git_is_staged.fish
linking ~/.config/fish/functions/git_is_stashed.fish
linking ~/.config/fish/functions/git_is_tag.fish
linking ~/.config/fish/functions/git_is_touched.fish
linking ~/.config/fish/functions/git_repository_root.fish
linking ~/.config/fish/functions/git_untracked_files.fish
linking ~/.config/fish/completions/brew.fish
linking ~/.config/fish/functions/_pisces_append.fish
linking ~/.config/fish/functions/_pisces_backspace.fish
linking ~/.config/fish/functions/_pisces_bind_pair.fish
linking ~/.config/fish/functions/_pisces_complete.fish
linking ~/.config/fish/functions/_pisces_jump.fish
linking ~/.config/fish/functions/_pisces_lookup.fish
linking ~/.config/fish/functions/_pisces_remove.fish
linking ~/.config/fish/functions/_pisces_skip.fish
linking ~/.config/fish/conf.d/pisces_key_bindings.fish
linking ~/.config/fish/functions/cprintf.fish
linking ~/.config/fish/completions/cprintf.fish
linking ~/.config/fish/functions/__sf_lib_section.fish
linking ~/.config/fish/functions/__sf_section_aws.fish
linking ~/.config/fish/functions/__sf_section_battery.fish
linking ~/.config/fish/functions/__sf_section_char.fish
linking ~/.config/fish/functions/__sf_section_conda.fish
linking ~/.config/fish/functions/__sf_section_dir.fish
linking ~/.config/fish/functions/__sf_section_docker.fish
linking ~/.config/fish/functions/__sf_section_dotnet.fish
linking ~/.config/fish/functions/__sf_section_exec_time.fish
linking ~/.config/fish/functions/__sf_section_exit_code.fish
linking ~/.config/fish/functions/__sf_section_git.fish
linking ~/.config/fish/functions/__sf_section_git_branch.fish
linking ~/.config/fish/functions/__sf_section_git_status.fish
linking ~/.config/fish/functions/__sf_section_golang.fish
linking ~/.config/fish/functions/__sf_section_haskell.fish
linking ~/.config/fish/functions/__sf_section_host.fish
linking ~/.config/fish/functions/__sf_section_jobs.fish
linking ~/.config/fish/functions/__sf_section_julia.fish
linking ~/.config/fish/functions/__sf_section_kubecontext.fish
linking ~/.config/fish/functions/__sf_section_line_sep.fish
linking ~/.config/fish/functions/__sf_section_node.fish
linking ~/.config/fish/functions/__sf_section_package.fish
linking ~/.config/fish/functions/__sf_section_php.fish
linking ~/.config/fish/functions/__sf_section_pyenv.fish
linking ~/.config/fish/functions/__sf_section_ruby.fish
linking ~/.config/fish/functions/__sf_section_rust.fish
linking ~/.config/fish/functions/__sf_section_time.fish
linking ~/.config/fish/functions/__sf_section_user.fish
linking ~/.config/fish/functions/__sf_section_vi_mode.fish
linking ~/.config/fish/functions/__sf_util_git_branch.fish
linking ~/.config/fish/functions/__sf_util_human_time.fish
linking ~/.config/fish/functions/__sf_util_set_default.fish
linking ~/.config/fish/functions/__sf_util_truncate_dir.fish
linking ~/.config/fish/functions/fish_mode_prompt.fish
linking ~/.config/fish/functions/fish_prompt.fish
linking ~/.config/fish/functions/fish_right_prompt.fish
linking ~/.config/fish/functions/__fasd_print_completions.fish
linking ~/.config/fish/functions/a.fish
linking ~/.config/fish/functions/d.fish
linking ~/.config/fish/functions/f.fish
linking ~/.config/fish/functions/fasd_cd.fish
linking ~/.config/fish/functions/s.fish
linking ~/.config/fish/functions/sd.fish
linking ~/.config/fish/functions/sf.fish
linking ~/.config/fish/functions/z.fish
linking ~/.config/fish/functions/zz.fish
linking ~/.config/fish/completions/a.fish
linking ~/.config/fish/completions/d.fish
linking ~/.config/fish/completions/f.fish
linking ~/.config/fish/completions/fasd.fish
linking ~/.config/fish/completions/fasd_cd.fish
linking ~/.config/fish/completions/s.fish
linking ~/.config/fish/completions/sd.fish
linking ~/.config/fish/completions/sf.fish
linking ~/.config/fish/completions/z.fish
linking ~/.config/fish/completions/zz.fish
linking ~/.config/fish/conf.d/plugin-fasd_init.fish
linking ~/.config/fish/functions/ssh.fish
linking ~/.config/fish/functions/wifi-password.fish
linking ~/.config/fish/functions/free.fish
linking ~/.config/fish/completions/g.fish
linking ~/.config/fish/conf.d/g2.fish
linking ~/.config/fish/functions/_grc_wrap.fish
linking ~/.config/fish/functions/cat.fish
linking ~/.config/fish/functions/cvs.fish
linking ~/.config/fish/functions/df.fish
linking ~/.config/fish/functions/diff.fish
linking ~/.config/fish/functions/dig.fish
linking ~/.config/fish/functions/g++.fish
linking ~/.config/fish/functions/gcc.fish
linking ~/.config/fish/functions/ifconfig.fish
linking ~/.config/fish/functions/ls.fish
linking ~/.config/fish/functions/make.fish
linking ~/.config/fish/functions/mount.fish
linking ~/.config/fish/functions/mtr.fish
linking ~/.config/fish/functions/netstat.fish
linking ~/.config/fish/functions/ping.fish
linking ~/.config/fish/functions/ps.fish
linking ~/.config/fish/functions/tail.fish
linking ~/.config/fish/functions/traceroute.fish
linking ~/.config/fish/functions/wdiff.fish
linking ~/.config/fish/conf.d/javahome.fish
Unable to find any JVMs matching version "1.8".
No Java runtime present, try --request to install.
linking ~/.config/fish/conf.d/masterconfig.fish
linking ~/.config/fish/functions/man.fish
added 17 packages in 7.99s

jorgebucaran / fisher

fisher command stuck after a few package updates #503