Fisher overwrites fish prompt on installation

jorgebucaran / fisher

A plugin manager for Fish

https://git.io/fisher

MIT License

7.74k stars 263 forks source link

Fisher overwrites fish prompt on installation #521

Closed carlosssanchez closed 5 years ago

carlosssanchez commented 5 years ago

After installing fisher with /curl https://git.io/fisher --create-dirs -sLo ~/.config/fish/functions/fisher.fish my fish prompt reverts to the original. This is the second time I've installed it and this happens, but at least this time I made a backup. Was my prompt configured incorrectly or is this expected from fisher? I don't understand why a plugin manager would affect the prompt.

jorgebucaran commented 5 years ago

@carlosssanchez Do you mean after installing a prompt with Fisher? Where is your fish_prompt.fish located? What directory?

carlosssanchez commented 5 years ago

Sorry I was just going over the backup to find out more. Just after running the curl command, it deleted fish_prompt.fish, fish_right_prompt.fish, humanize_duration.fish, pwd_info.fish, pwd_is_home.fish, basically several files all related to the prompt that I had as helper functions inside .config/fish/functions. All other fish files that don't manage the prompt are untouched.

jorgebucaran commented 5 years ago

@carlosssanchez Just after running the curl command, it deleted...

What do you mean by it? curl or Fisher?

carlosssanchez commented 5 years ago

Both? I mean running the installation command, I was next greeted by the new "Welcome to fish" prompt. The first time I installed fisher and this happened was a few months ago, but I installed it from Arch's AUR. fishpromptdeleted

Here's a screenshot of my backup .config/functions in the D/f/functions folder (top terminal) and the current one (bottom). I just installed the fzf plugin so those files are irrelevant in the bottom.

jorgebucaran commented 5 years ago

@carlosssanchez What installation command? You didn't say anything about AUR before.

Now, let's break this down:

curl is just copying a file to a directory, so it isn't the problem
you haven't run fisher yet, so we know the problem can't be Fisher either

It must be the AUR package? I have no idea who maintains it, but the only installation method that I support at the moment is described in the README. I recommend you use that and nothing else.

Ah, it seems @Scrumplex maintains a package in the AUR here: https://aur.archlinux.org/packages/fisher.

Please login to the AUR and leave a comment for them there. You shouldn't mix installation methods, use one or the other. You may also be interested in changing the installation prefix.