Add support to install plugins from branch names with slashes

jorgebucaran / fisher

A plugin manager for Fish

https://git.io/fisher

MIT License

7.71k stars 263 forks source link

Add support to install plugins from branch names with slashes #588

Closed joseluisq closed 3 years ago

joseluisq commented 4 years ago

It's not possible to install a plugins from a branch that uses for example Gitflow conventions due that branch names can contain slashes and the _fisher_fetch function because is splinting a string based on slashes as well, throws an error when is trying to fetch the tarball.

fisher 3.3.0

~> fisher add username/plugin@feature/some-feature
fetching username/plugin
fisher: cannot add username/plugin -- is this a valid plugin?

jorgebucaran commented 4 years ago

@joseluisq Maybe we can rewrite that part and come up with an alternative that uses less code and supports this particular use case. I'll keep this on my radar. PR welcome, of course. Thanks.

jorgebucaran commented 3 years ago

Implemented in 4.1.0. 🎉