Use HTTPS for installation

jorgebucaran / fisher

A plugin manager for Fish

https://git.io/fisher

MIT License

7.71k stars 263 forks source link

Use HTTPS for installation #627

Closed rany2 closed 3 years ago

rany2 commented 3 years ago

Using HTTPS would help prevent:

accidentally running a captive portal login screen as a fish script and sourcing it
and other obvious security and privacy benefits of HTTPS

jorgebucaran commented 3 years ago

accidentally running a captive portal login screen

How could this happen if GitHub owns Git.io?

rany2 commented 3 years ago

You know when you're connected to hotel WiFi and you need to login to the WiFi network? If it's over http then it could load the captive login screen whereas with https this isn't possible.

jorgebucaran commented 3 years ago

Got it! Thanks and sorry for the delay here.