search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.71k stars 263 forks source link

Installation instructions do not work in fish 2.7.1 #663

Closed niderhoff closed 3 years ago

niderhoff commented 3 years ago

Hello,

I am new to fish, so I can say I definitely not know what I am doing here. However, if I try to run the installation instructions on a default ubuntu install of fish, they don't work:

niid@DESKTOP-9OF9U33 ~> fish -v
fish, version 2.7.1
niid@DESKTOP-9OF9U33 ~> echo $SHELL
/usr/bin/fish
niid@DESKTOP-9OF9U33 ~> curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher
fish: Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher

If I do the suggested adjustment, I run into the following error:

niid@DESKTOP-9OF9U33 ~> curl -sL https://git.io/fisher | source; and fisher install jorgebucaran/fisher
- (line 2): Unsupported use of '||'. In fish, please use 'COMMAND; or COMMAND'.
    set --query fisher_path || set --local fisher_path $__fish_config_dir
                             ^
from sourcing file -
        called on standard input

source: Error while reading file '-'

After I upgrade to fish >3 it seems to work. I suggest we add a note to the README with the minimum required fish version.