jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.55k stars 257 forks source link

Error while installing 'tide' #668

Closed TheEvilSkeleton closed 3 years ago

TheEvilSkeleton commented 3 years ago

Hi,

I ran the two first commands in the README, and I encountered an issue.

TheEvilSkeleton@TheMainLaptop ~> curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher
fisher install version 4.3.0
Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD
Installing jorgebucaran/fisher
           /home/TheEvilSkeleton/.config/fish/functions/fisher.fish
           /home/TheEvilSkeleton/.config/fish/completions/fisher.fish
Installed 1 plugin/s
TheEvilSkeleton@TheMainLaptop ~> fisher install ilancosman/tide
fisher install version 4.3.0
Fetching https://codeload.github.com/ilancosman/tide/tar.gz/HEAD
Installing ilancosman/tide
           /home/TheEvilSkeleton/.config/fish/functions/_tide_decolor.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_detect_os.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_chruby.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_cmd_duration.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_context.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_git.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_jobs.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_nvm.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_os.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_php.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_prompt_char.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_pwd.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_rust.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_status.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_time.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_vi_mode.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_item_virtual_env.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_left_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_right_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_sub_bug-report.fish
           /home/TheEvilSkeleton/.config/fish/functions/_tide_sub_configure.fish
           /home/TheEvilSkeleton/.config/fish/functions/fish_mode_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/fish_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/fish_right_prompt.fish
           /home/TheEvilSkeleton/.config/fish/functions/tide
           /home/TheEvilSkeleton/.config/fish/functions/tide.fish
           /home/TheEvilSkeleton/.config/fish/conf.d/_tide_init.fish
           /home/TheEvilSkeleton/.config/fish/conf.d/_tide_interactive_init.fish
           /home/TheEvilSkeleton/.config/fish/completions/tide.fish
status: Subcommand 'dirname' is not valid
fish: _load_config: command not found...
~/.config/fish/conf.d/_tide_init.fish (line 23): 
    _load_config lean
    ^
in function '_tide_init_install'
    called on line 1 of file ~/.config/fish/functions/fisher.fish
in event handler: handler for generic event “_tide_init_install”
    called on line 176 of file ~/.config/fish/functions/fisher.fish
fish: _tide_finish: command not found...
~/.config/fish/conf.d/_tide_init.fish (line 24): 
    _tide_finish
    ^
in function '_tide_init_install'
    called on line 1 of file ~/.config/fish/functions/fisher.fish
in event handler: handler for generic event “_tide_init_install”
    called on line 176 of file ~/.config/fish/functions/fisher.fish
Configure tide prompt? [Y/n] n

I am using Tilix terminal on Fedora 33. I also cleared ~/.config/fish before installing. Perhaps this is a Tide issue?

jorgebucaran commented 3 years ago

Fish version?

TheEvilSkeleton commented 3 years ago

fish, version 3.1.2. I knew there was something missing but I couldn't figure it out. Sorry.

TheEvilSkeleton commented 3 years ago

@jorgebucaran I found the issue. I was using an outdated version of fish; I bumped it to 3.2.0 and it worked! Sorry for the trouble.

jorgebucaran commented 3 years ago

I knew there was something missing but I couldn't figure it out.

Tide requires Fish ≥ 3.2.0. It's right there in the README.