jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.55k stars 257 forks source link

`fisher update` returns conflicting files errors and removes `fish_plugins` file #670

Closed jimblue closed 3 years ago

jimblue commented 3 years ago

Hello,

I'm having some issues with fisher update command, when I run it I get the following errors :

fisher update
fisher update version 4.3.0
Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD
Fetching https://codeload.github.com/adriaanzon/fish-artisan-completion/tar.gz/HEAD
Fetching https://codeload.github.com/dracula/fish/tar.gz/HEAD
Fetching https://codeload.github.com/jethrokuan/fzf/tar.gz/HEAD
Fetching https://codeload.github.com/jethrokuan/z/tar.gz/HEAD
fisher: Cannot install "jorgebucaran/fisher": please remove or move conflicting files first:
        /Users/jimblue/.config/fish/functions/fisher.fish
fisher: Cannot install "adriaanzon/fish-artisan-completion": please remove or move conflicting files first:
        /Users/jimblue/.config/fish/functions/artisan.fish
        /Users/jimblue/.config/fish/completions/artisan.fish
        /Users/jimblue/.config/fish/completions/php.fish
fisher: Cannot install "dracula/fish": please remove or move conflicting files first:
        /Users/jimblue/.config/fish/conf.d/dracula.fish
fisher: Cannot install "jethrokuan/fzf": please remove or move conflicting files first:
        /Users/jimblue/.config/fish/functions/__fzf_cd.fish
        /Users/jimblue/.config/fish/functions/__fzf_complete.fish
        /Users/jimblue/.config/fish/functions/__fzf_complete_preview.fish
        /Users/jimblue/.config/fish/functions/__fzf_find_file.fish
        /Users/jimblue/.config/fish/functions/__fzf_get_dir.fish
        /Users/jimblue/.config/fish/functions/__fzf_open.fish
        /Users/jimblue/.config/fish/functions/__fzf_parse_commandline.fish
        /Users/jimblue/.config/fish/functions/__fzf_reverse_isearch.fish
        /Users/jimblue/.config/fish/functions/__fzfcmd.fish
        /Users/jimblue/.config/fish/conf.d/fzf.fish
fisher: Cannot install "jethrokuan/z": please remove or move conflicting files first:
        /Users/jimblue/.config/fish/functions/__z.fish
        /Users/jimblue/.config/fish/functions/__z_add.fish
        /Users/jimblue/.config/fish/functions/__z_clean.fish
        /Users/jimblue/.config/fish/functions/__z_complete.fish
        /Users/jimblue/.config/fish/conf.d/z.fish

It's also removing my symlinked fish_plugins file, so if I run fisher update again it I get the following error :

fisher: "/Users/jimblue/.config/fish/fish_plugins" file not found: "update"

I usually run fisher update from a fish alias to update everything on my mac :

alias update 'brew update; brew upgrade; brew cleanup; brew doctor; npm install npm -g && npm update -g; composer global update; fisher update; z --clean'

But the problem is the same if a run fisher update directly too.

Hope this give enough information ? 😃

jimblue commented 3 years ago

It's also worth mentioning that fisher list doesn't seem to work even if a fish_plugins file exist :

Screenshot 2021-03-28 at 15 22 56
jorgebucaran commented 3 years ago

Fisher's state seems to be broken (not sure, but this could happen if you tamper with $fisher_ universal variables or upgrade from Fisher 3 incorrectly) and the easiest way to go back to normal is to reinstall everything.

So, try removing all plugins, including Fisher, and reinstalling everything.

jimblue commented 3 years ago

Ok just understood, I was using the installation snippet from the doc which was erasing overwriting my fish_plugins.

I've change the fisher install for fisher update like bellow and now everything working !

if status is-interactive && ! functions -q fisher
  curl -sL https://git.io/fisher | source && fisher update
end

Thank you for your help 😄