search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.55k stars 257 forks source link

Local function not persisted across different invocations of the shell #676

Closed srizzling closed 3 years ago

srizzling commented 3 years ago

I'm having some weird behavior I don't really understand..

Here is the content of my fish_plugins file: 

jethrokuan/z
jorgebucaran/autopair.fish
jethrokuan/fzf
oh-my-fish/plugin-grc
dracula/fish
/Users/sriram/Development/nbos-fish
jorgebucaran/fisher

that file is located here: 

/Users/sriram/.config/fish

here is how my plugin dirs look like:

~/Development/nbos-fish on  main
λ tree
.
├── README.md
├── completions
│   └── _nbos_saml_completions.fish
├── conf.d
└── functions
    ├── _nbos_misc.fish
    └── _nbos_saml.fish

I am struggling to load the plugin in this path: /Users/sriram/Development/nbos-fish on new shells. It loads after I run fisher update.

See the steps below:

~/.config/fish
❯ exec fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish

~/.config/fish
λ nbos_saml
fish: Unknown command: nbos_saml

~/.config/fish
❯ fisher update
fisher update version 4.3.0
Fetching https://codeload.github.com/jethrokuan/z/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/autopair.fish/tar.gz/HEAD
Fetching https://codeload.github.com/jethrokuan/fzf/tar.gz/HEAD
Fetching https://codeload.github.com/oh-my-fish/plugin-grc/tar.gz/HEAD
Fetching https://codeload.github.com/dracula/fish/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD
Installing jethrokuan/z
           /Users/sriram/.config/fish/functions/__z.fish
           /Users/sriram/.config/fish/functions/__z_add.fish
           /Users/sriram/.config/fish/functions/__z_clean.fish
           /Users/sriram/.config/fish/functions/__z_complete.fish
           /Users/sriram/.config/fish/conf.d/z.fish
Installing jorgebucaran/autopair.fish
           /Users/sriram/.config/fish/functions/_autopair_backspace.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_left.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_right.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_same.fish
           /Users/sriram/.config/fish/functions/_autopair_tab.fish
           /Users/sriram/.config/fish/conf.d/autopair.fish
Installing jethrokuan/fzf
           /Users/sriram/.config/fish/functions/__fzf_cd.fish
           /Users/sriram/.config/fish/functions/__fzf_complete.fish
           /Users/sriram/.config/fish/functions/__fzf_complete_preview.fish
           /Users/sriram/.config/fish/functions/__fzf_find_file.fish
           /Users/sriram/.config/fish/functions/__fzf_get_dir.fish
           /Users/sriram/.config/fish/functions/__fzf_open.fish
           /Users/sriram/.config/fish/functions/__fzf_parse_commandline.fish
           /Users/sriram/.config/fish/functions/__fzf_reverse_isearch.fish
           /Users/sriram/.config/fish/functions/__fzfcmd.fish
           /Users/sriram/.config/fish/conf.d/fzf.fish
Installing oh-my-fish/plugin-grc
           /Users/sriram/.config/fish/functions/grc.wrap.fish
           /Users/sriram/.config/fish/conf.d/grc.fish
Installing dracula/fish
           /Users/sriram/.config/fish/conf.d/dracula.fish
Installing /Users/sriram/Development/nbos-fish
           /Users/sriram/.config/fish/functions/_nbos_misc.fish
           /Users/sriram/.config/fish/functions/_nbos_saml.fish
           /Users/sriram/.config/fish/completions/_nbos_saml_completions.fish
Installing jorgebucaran/fisher
           /Users/sriram/.config/fish/functions/fisher.fish
           /Users/sriram/.config/fish/completions/fisher.fish
Updated 7 plugin/s

~/.config/fish  1s
λ nbos_saml
[  ABRT  ] account is empty, usage: nbos_saml <account> <env_name> <user>

~/.config/fish
❯ exec fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish

~/.config/fish
λ nbos_saml
fish: Unknown command: nbos_saml

I am using fisher version..

λ fisher --version
fisher, version 4.3.0
jorgebucaran commented 3 years ago

What happens if you rename _nbos_saml.fish to nbos_saml.fish?

srizzling commented 3 years ago

It kinda worked. nbos_saml seems to have persisted - I have another file with a few functions - and it doesn't seem to find it across the next session.

I'm assuming I'll need move my nbos_abort function out of nbos_misc.fish file and put it into another function?

~/Development/nbos-fish on  main ?
λ tree
.
├── README.md
├── completions
│   └── _nbos_saml_completions.fish
├── conf.d
└── functions
    ├── nbos_misc.fish
    └── nbos_saml.fish

3 directories, 4 files

~/Development/nbos-fish on  main ?
λ fisher update
fisher update version 4.3.0
Fetching https://codeload.gFietthcuhbi.ncgo m[j4emthhtrtopksu:a/n//cfozdfe/ltoaard..ggzi/tHhEuAbD.
(oBm[jme
throkuan/z/tar.gz/HEAD
Fetching https://codeload.github.com/dracula/fish/tar.gz/HEAD
Fetching https://codeload.github.com/oh-my-fish/plugin-grc/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/autopair.fish/tar.gz/HEAD
Installing jethrokuan/z
           /Users/sriram/.config/fish/functions/__z.fish
           /Users/sriram/.config/fish/functions/__z_add.fish
           /Users/sriram/.config/fish/functions/__z_clean.fish
           /Users/sriram/.config/fish/functions/__z_complete.fish
           /Users/sriram/.config/fish/conf.d/z.fish
Installing jorgebucaran/autopair.fish
           /Users/sriram/.config/fish/functions/_autopair_backspace.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_left.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_right.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_same.fish
           /Users/sriram/.config/fish/functions/_autopair_tab.fish
           /Users/sriram/.config/fish/conf.d/autopair.fish
Installing jethrokuan/fzf
           /Users/sriram/.config/fish/functions/__fzf_cd.fish
           /Users/sriram/.config/fish/functions/__fzf_complete.fish
           /Users/sriram/.config/fish/functions/__fzf_complete_preview.fish
           /Users/sriram/.config/fish/functions/__fzf_find_file.fish
           /Users/sriram/.config/fish/functions/__fzf_get_dir.fish
           /Users/sriram/.config/fish/functions/__fzf_open.fish
           /Users/sriram/.config/fish/functions/__fzf_parse_commandline.fish
           /Users/sriram/.config/fish/functions/__fzf_reverse_isearch.fish
           /Users/sriram/.config/fish/functions/__fzfcmd.fish
           /Users/sriram/.config/fish/conf.d/fzf.fish
Installing oh-my-fish/plugin-grc
           /Users/sriram/.config/fish/functions/grc.wrap.fish
           /Users/sriram/.config/fish/conf.d/grc.fish
Installing dracula/fish
           /Users/sriram/.config/fish/conf.d/dracula.fish
Installing /Users/sriram/Development/nbos-fish
           /Users/sriram/.config/fish/functions/nbos_misc.fish
           /Users/sriram/.config/fish/functions/nbos_saml.fish
           /Users/sriram/.config/fish/completions/_nbos_saml_completions.fish
Installing jorgebucaran/fisher
           /Users/sriram/.config/fish/functions/fisher.fish
           /Users/sriram/.config/fish/completions/fisher.fish
Updated 7 plugin/s

~/Development/nbos-fish on  main ? 1s
λ nbos_saml
[  ABRT  ] account is empty, usage: nbos_saml <account> <env_name> <user>

~/Development/nbos-fish on  main ?
❯ exec fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish

~/Development/nbos-fish on  main ?
λ nbos_saml
fish: Unknown command: nbos_abort
~/.config/fish/functions/nbos_saml.fish (line 8):
        nbos_abort "account is empty, usage: nbos_saml <account> <env_name> <user>"
        ^
in function 'nbos_saml'
srizzling commented 3 years ago

Ok - i ended up just spilitting each function into seperate files - and it seems to work!


Development/nbos-fish/functions on  main ?
λ fisher update
fisher update version 4.3.0
Fetching https://codeload.github.com/jethrokuan/fzf/tar.gz/HEAD
Fetching https://codeload.github.com/jethrokuan/z/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/autopair.fish/tar.gz/HEAD
Fetching https://codeload.github.com/oh-my-fish/plugin-grc/tar.gz/HEAD
Fetching https://codeload.github.com/dracula/fish/tar.gz/HEAD
Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD
Installing jethrokuan/z
           /Users/sriram/.config/fish/functions/__z.fish
           /Users/sriram/.config/fish/functions/__z_add.fish
           /Users/sriram/.config/fish/functions/__z_clean.fish
           /Users/sriram/.config/fish/functions/__z_complete.fish
           /Users/sriram/.config/fish/conf.d/z.fish
Installing jorgebucaran/autopair.fish
           /Users/sriram/.config/fish/functions/_autopair_backspace.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_left.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_right.fish
           /Users/sriram/.config/fish/functions/_autopair_insert_same.fish
           /Users/sriram/.config/fish/functions/_autopair_tab.fish
           /Users/sriram/.config/fish/conf.d/autopair.fish
Installing jethrokuan/fzf
           /Users/sriram/.config/fish/functions/__fzf_cd.fish
           /Users/sriram/.config/fish/functions/__fzf_complete.fish
           /Users/sriram/.config/fish/functions/__fzf_complete_preview.fish
           /Users/sriram/.config/fish/functions/__fzf_find_file.fish
           /Users/sriram/.config/fish/functions/__fzf_get_dir.fish
           /Users/sriram/.config/fish/functions/__fzf_open.fish
           /Users/sriram/.config/fish/functions/__fzf_parse_commandline.fish
           /Users/sriram/.config/fish/functions/__fzf_reverse_isearch.fish
           /Users/sriram/.config/fish/functions/__fzfcmd.fish
           /Users/sriram/.config/fish/conf.d/fzf.fish
Installing oh-my-fish/plugin-grc
           /Users/sriram/.config/fish/functions/grc.wrap.fish
           /Users/sriram/.config/fish/conf.d/grc.fish
Installing dracula/fish
           /Users/sriram/.config/fish/conf.d/dracula.fish
Installing /Users/sriram/Development/nbos-fish
           /Users/sriram/.config/fish/functions/_nbos_abort.fish
           /Users/sriram/.config/fish/functions/account2id.fish
           /Users/sriram/.config/fish/functions/coverage
           /Users/sriram/.config/fish/functions/nbos_saml.fish
           /Users/sriram/.config/fish/completions/_nbos_saml_completions.fish
Installing jorgebucaran/fisher
           /Users/sriram/.config/fish/functions/fisher.fish
           /Users/sriram/.config/fish/completions/fisher.fish
Updated 7 plugin/s

Development/nbos-fish/functions on  main ? 1s
λ nbos_saml
[  ABRT  ] account is empty, usage: nbos_saml <account> <env_name> <user>

Development/nbos-fish/functions on  main ?
❯ _nbos_abort
[  ABRT  ]

Development/nbos-fish/functions on  main ?
λ exec fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish

Development/nbos-fish/functions on  main ?
λ nbos_saml
[  ABRT  ] account is empty, usage: nbos_saml <account> <env_name> <user>

~/Development/nbos-fish on  main ?
❯ tree
.
├── README.md
├── completions
│   └── _nbos_saml_completions.fish
├── conf.d
└── functions
    ├── _nbos_abort.fish
    ├── account2id.fish
    ├── coverage
    └── nbos_saml.fish

4 directories, 5 files
srizzling commented 3 years ago

Thanks for the quick reply! I'll close this ticket.