search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.55k stars 257 forks source link

prevent error on unzipping packages #685

Closed mehdipourfar closed 2 years ago

mehdipourfar commented 2 years ago

I got this error on installing fisher: fisher install version 4.3.0 Fetching https://codeload.github.com/jorgebucaran/fisher/tar.gz/HEAD fisher: Invalid plugin name or host unavailable: "jorgebucaran/fisher" and I've found out that piping the results of curl into tar will causes the problem. This commit fixes that.

jorgebucaran commented 2 years ago

Hi, @mehdipourfar, thank you! What's your OS and Fish version?

mehdipourfar commented 2 years ago

Hi

lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:    20.04
Codename:   focal
fish --version
fish, version 3.3.1
curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
Release-Date: 2020-01-08
tar --version
tar (GNU tar) 1.30
jorgebucaran commented 2 years ago

Could you perhaps prepare an image with the same OS, tar, and curl version where we can reproduce this issue? I don't really want to merge something until I understand for whom Fisher is currently broken.

mehdipourfar commented 2 years ago

Finally I've found out the problem. I don't know when and why I've had added this in my fish functions:

function curl
    command curl -w "\n" $argv
end
jorgebucaran commented 2 years ago

Do you have a curlrc file with a custom curl configuration?

mehdipourfar commented 2 years ago

Do you have a curlrc file with a custom curl configuration?

no

jorgebucaran commented 2 years ago

Misread your comment. I see now that the problem was you were overriding curl in a function. 👍