search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.53k stars 257 forks source link

fisher uses a seemingly undocumented github api endpoint #699

Closed anakimluke closed 2 years ago

anakimluke commented 2 years ago

Fisher makes a request to codeload.github.com to retrieve the tarball of the desired plugin. Upon research(basically googling for +"codeload.github.com" +site:docs.github.com), I couldn't find proper documentation for this endpoint.

As there are no guarantees this will work indefinitely or that I'll have consistent behavior, I suggest moving to the well-documented rest api. Then I'd also feel more comfortable with advanced usage of the api, such as the ability to specify a "tag, branch, or commit".

Relevant section: https://docs.github.com/en/rest/reference/repos#download-a-repository-archive-tar

jorgebucaran commented 2 years ago

That makes a lot of sense @anakimluke, thank you for digging that up. Is this something you'd like to work on? Migrating the endpoints and making sure it still gives us what Fisher needs.

jorgebucaran commented 2 years ago

Thank you, @anakimluke! I'll include this in the next release. 🎉