search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.7k stars 263 forks source link

Use current fish path instead of fish command #716

Closed IlanCosman closed 2 years ago

IlanCosman commented 2 years ago

fish may not be an available command, for example if it was installed through brew. Whenever I rm -r ~/.config/fish/ on my mac (for developing Tide), I have to fish_add_path /opt/homebrew/bin/ before I run my fisher command. Instead, lets just guarantee a valid command by using the path to the current instance of fish. Tide already does this and it has worked fine so far.

jorgebucaran commented 2 years ago

@IlanCosman This requires at least what version of Fish?

IlanCosman commented 2 years ago

Do you mean when did status fish-path get released? It's been there since Fish 3.0 https://github.com/fish-shell/fish-shell/commit/e212269ab1b29a1456ce47c335ae57fb5789ea79.

And I'm pretty sure foo=bar as a way of setting variables has been around for a while as well. Can always change it to set if not.

jorgebucaran commented 2 years ago

fish may not be an available command, for example if it was installed through brew.

Doesn't brew put Fish in your PATH? I install Fish via brew too and I've never had to do that. Or I could've added it myself and forgotten about it. 😅

IlanCosman commented 2 years ago

Doesn't brew put Fish in your PATH?

/opt/homebrew/bin/ isn't in PATH by default. Has to get added, If you want to test it, back up your ~/.config/fish and then delete it. You shouldn't have access to any commands installed through brew.

jorgebucaran commented 2 years ago

Yes. Then I must have added it to my PATH. Makes sense. 👍