search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.7k stars 263 forks source link

Unable to install plugins from Git URL #732

Closed yonkeltron closed 2 years ago

yonkeltron commented 2 years ago

Hi,

I am a huge fan of Fisher and looking to use it even more. In trying to adopt it, I have noticed that I'm unable to install plugins from private Git hosts, even when providing a full Git URL. For example, my company has a private git host but the following command yields an error:

❯ fisher install https://private.git.host/project/plugin
Fetching https://api.github.com/repos/https://private.git.host/project/plugin/tarball/HEAD
fisher: Invalid plugin name or host unavailable: "https://private.git.host/project/plugin"

Some crucial info about my environment, since I am running macOS Monterey (12.5):

❯ fish --version
fish, version 3.5.1
❯ fisher --version
fisher, version 4.4.2

If there is any other info I can provide, please let me know. Also happy to test any fixes or some such! Thanks so much for all your hard work, and I look forward to your reply.

Thanks, +Jonathan

jorgebucaran commented 2 years ago

Hi @yonkeltron, unfortunately, we don't support that anymore. We had some (poor) support for this a few years ago, but it was laboriously tricky to implement, so I ended up removing it in Fisher 4. I'm not against giving it another shot if done properly this time.

yonkeltron commented 2 years ago

Hey @jorgebucaran, thanks so much for getting back to me with an explanation.

What would you think of a CLI option?

We could do something such as -u or --url which would allow you to provide a URL directly and bypass the normal determination processes.

Alternatively we could provide -h or --host to simply provide the Git host as a prefix.

Would either of those be worth it? I am happy to try and work up some example code to get fast feedback from you before opening a proper PR.

Thanks, +Jonathan