search

jorgebucaran / fisher

A plugin manager for Fish
https://git.io/fisher
MIT License
7.53k stars 257 forks source link

Update subcommand removes local directories #751

Closed daleeidd closed 1 year ago

daleeidd commented 1 year ago

In fish_plugins I had:

…
~/Developer/Fish/natural-selection
…

Executing fisher update produced the following output:

fisher update version 4.4.3
…
fisher: Invalid plugin name or host unavailable: "~/developer/fish/natural-selection"
Removing /Users/Dale/Developer/Fish/natural-selection
…

The files are now gone.

daleeidd commented 1 year ago

Actually this might be a false positive. I remember now that I removed this directory months ago when doing some housekeeping. So I must of forgotten to update the fish_plugins file to the git repository.

"fisher: Invalid plugin name or host unavailable:" must be fisher not finding the directory and the subsequent "Removing" means it is removing the entry from fish_plugins. I think the messaging could be improved as it gave me the wrong impression that fisher removed a local directory which was quite a scare.

jorgebucaran commented 1 year ago

Suggestions?

daleeidd commented 1 year ago

"Removing" could be "Uninstalling" or "Removing entry" and print the entry name (above it expanded the path).

Could go further with the error message being specific (ie only mentioning either invalid plugin name, host unavailable or file not found etc).

jorgebucaran commented 1 year ago

Cool, thanks! If you send me a PR I can take a look.