Closed PatrickF1 closed 3 years ago
Good question. I prefer test
and use it everywhere, not just in Fish.
But this is probably a convention I carried over from the JavaScript world, which is irrelevant in Fish. I'm willing to change everything to tests
if we can make a good argument for it.
fish
files are plural: functions, completions, fish_plugins, fish_variables.tests
.tests
.What else do you have?
Have you done a broad survey of fish plugins with tests to see what they've done? I'm assuming you have so know more than me. The only other plugin I've found not written by you that uses Fishtape is by Tide, and Ilan uses tests. See https://github.com/IlanCosman/tide/tree/main/functions/tide/tests
Well, there's my argument then. I'm going to use tests
for now but can be convinced to change if other people change too. Thanks Jorge!
Good enough for me! 🙌
Hi Jorge, sorry if this is a bit too nit-picky, but I was wondering on your thoughts on whether plugins that use fishtape should put their tests in a dir called
test
ortests
? I was thinkingtests
since all the other traditional fish files are plural (functions, completions, fish_plugins, fish_variables). However, in this plugin you called ittest
. Now I'm not sure what the consensus is. What do you think?