search

jorgebucaran / hydro

Ultra-pure, lag-free prompt with async Git status—just for Fish
MIT License
637 stars 53 forks source link

Use pipe instead of 'latin letter dental click' #15

Closed kevinastock closed 2 years ago

kevinastock commented 3 years ago

The pipestatus display is currently using utf-8's 'latin letter dental click' instead of pipe: https://www.fileformat.info/info/unicode/char/01c0/index.htm

If changing this always is a problem, a configurable variable would be super for displays which don't handle utf-8 well.

kidonng commented 3 years ago

Quoting from https://github.com/jorgebucaran/hydro/issues/16#issuecomment-840975364:

Pipestatus separator ǀ doesn't look good with JetBrains Mono on kitty...

Making the pipe symbol configurable sounds reasonable.

Maybe you can work on this so we don't have to open a new PR?

jorgebucaran commented 3 years ago

If changing this always is a problem, a configurable variable would be super for displays which don't handle utf-8 well.

I suppose you ran into this using one of those displays. Could you explain what display was it and why you were using it?

kevinastock commented 3 years ago

I'm using Putty in a locked down enterprise environment. It's not ideal. I've applied this patch in that environment and it's not a problem for me to maintain. I happily use hydro as-is in my other environments.

jorgebucaran commented 3 years ago

If you could change this to make the separator configurable, I'd probably merge it. We'll just need a new variable and updated documentation.

jorgebucaran commented 2 years ago

Changed it to whitespace in 5d06a596f75ce397d6c92eb47f05601ad5645710, but we could introduce a new Hydro variable for this.