search

jorgebucaran / nvm.fish

The Node.js version manager you'll adore, crafted just for Fish
https://git.io/nvm.fish
MIT License
2.08k stars 69 forks source link

feat(node): use local node binary if existing #77

Closed Neonox31 closed 5 years ago

Neonox31 commented 5 years ago

Useful when node is installed as a dependency in the package.json.

jorgebucaran commented 5 years ago

@Neonox31 Thanks! Could you explain why node would be installed as a dependency in pkg json?

Neonox31 commented 5 years ago

@jorgebucaran Adding node as dependency allows to be sure using the correct supported version defined by the project. It is smarter than using engines package.json property in my point of view.

jorgebucaran commented 5 years ago

@Neonox31 TIL. Thanks. Do you have any links that support or talk about it? I'm not familiar with this practice.

Neonox31 commented 5 years ago

@jorgebucaran Sure, here is a link : https://nitayneeman.com/posts/standardizing-node.js-version-in-an-npm-package/

jorgebucaran commented 5 years ago

Excellent. I'll have a look over the weekend and try to merge this very soon. Thanks again! 👋

jorgebucaran commented 5 years ago

@Neonox31 The new version of this package will not include automatic version switching, so we don't need this anymore. The good news is I'll reuse some of this to document how to add it yourself.

See #75.