search

jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces
https://git.io/super
MIT License
1.57k stars 78 forks source link

closes #150 Move to terser #156

Closed osdevisnot closed 5 years ago

osdevisnot commented 5 years ago

closes #150 Move to Terser

codecov-io commented 5 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #156   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         183    183           
  Branches       52     52           
=====================================
  Hits          183    183

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 4691379...59e0bda. Read the comment docs.

osdevisnot commented 5 years ago

@jorgebucaran I had to move from babel-env to babel-preset-env to remove default generated .babelrc and be able to use the babel config from package.json.

jorgebucaran commented 5 years ago

@osdevisnot Thanks! πŸŽ‰

One problem though. Any idea why jest fails when I run npm test locally?

Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     β€’ To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     β€’ If you need a custom transformation specify a "transform" option in your config.
     β€’ If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.
osdevisnot commented 5 years ago

Um, that's new. I'm sure you did npm install after cloning/get latest.

jorgebucaran commented 5 years ago

Yeah, I did. I'd never seen that error before. I'll keep trying.

osdevisnot commented 5 years ago

And you are on at least node 8 or above?

jorgebucaran commented 5 years ago

@osdevisnot Ah, yeah, that was it! I was using Node 7 for some reason. πŸ˜†

osdevisnot commented 5 years ago

Glad it worked for you πŸ‘πŸ‘