jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces

https://git.io/super

MIT License

1.57k stars 78 forks source link

typescript foundation #158

Closed osdevisnot closed 5 years ago

osdevisnot commented 5 years ago

Tasks Completed:

[x] Create type definitions for custom matcher used in tests
[x] Configure tests to use ts-jest over jest and babel
[x] Remove babel config from package.json
[x] Refactor builds to use rollup with rollup.config.js over commands in scripts section of package.json
[x] Repoint main, module and typyings fields in package.json to dist
[x] Add new packages to package.json
[x] Remove existing .d.ts file as this will now be auto generated.

Tasks Pending:

[ ] Match type definitions for public functions
[ ] add better types for internal functions
[ ] use more typescript features (rest/spread, arrow functions, Map, etc.)
[ ] switch to ts strict mode

codecov-io commented 5 years ago

Codecov Report

Merging #158 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #158   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         183    196   +13     
  Branches       52     64   +12     
=====================================
+ Hits          183    196   +13

Impacted Files	Coverage Δ
src/superfine.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c08e20...90f355e. Read the comment docs.

osdevisnot commented 5 years ago

@jorgebucaran @mindplay-dk this is continuation of TS porting efforts that were being discussed in #155. Currently this is on a branch in my-fork and the PR is against master of this repo.

jorgebucaran commented 5 years ago

The codebase has changed quite a bit. If this is going to happen, we might as well start from scratch.