search

jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces
https://git.io/super
MIT License
1.56k stars 78 forks source link

Is using custom `events` property for DOM element really future proof? #159

Closed wanton7 closed 5 years ago

wanton7 commented 5 years ago

Browsers could add events property for DOM elements in the future and break superfine. Because standard DOM element properties follow camelCase naming convention using snake_case convention for property name like superfine_events instead should be quite future proof.

jorgebucaran commented 5 years ago

Or _events. I think I can address that in a future release. No problem.

mindplay-dk commented 5 years ago

I never noticed this change. @jorgebucaran I thought you were dead set against injecting anything into DOM elements? (if not, then why not go all the way and store last propert state in there as well? and remove the need for manual state management on the consumer's part like I've been pushing for in the past?)

jorgebucaran commented 5 years ago

I'm not dead set against it, but I'm going to allow this one.