search

jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces
https://git.io/super
MIT License
1.57k stars 78 forks source link

change patch semantics to append mode only for fragments #175

Closed osdevisnot closed 4 years ago

osdevisnot commented 5 years ago

This is another possible fixe for #172. We change patch semantics to use append to container like in v6 but only for DocumentFragments.

codecov-io commented 5 years ago

Codecov Report

Merging #175 into master will increase coverage by 0.43%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage    47.5%   47.93%   +0.43%     
==========================================
  Files           1        1              
  Lines         120      121       +1     
==========================================
+ Hits           57       58       +1     
  Misses         63       63
Impacted Files Coverage Δ
src/index.js 47.93% <100%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4d87a8...47f0754. Read the comment docs.

jorgebucaran commented 5 years ago

@osdevisnot How come this a "possible" fix? Does this fix your issue or not? 😂

osdevisnot commented 5 years ago

Oh my apologies.

It does fix the original issue.

jorgebucaran commented 5 years ago

@osdevisnot This is the other option we have, I guess.

osdevisnot commented 5 years ago

@jorgebucaran yes this is an option too. Let me know if you would like something revised here.

jorgebucaran commented 5 years ago

@osdevisnot Not at the moment, I just need time to review this carefully and study its implications. Have you found anything so far?