jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces
https://git.io/super
MIT License
1.57k stars 78 forks source link

Minor improvements to picodom.d.ts #59

Closed mindplay-dk closed 6 years ago

mindplay-dk commented 6 years ago

Use default type-argument of {} for VNode type, remove redundant type-arguments.

Also, make patch accept Element rather than HTMLElement - an SVGElement is not an HTMLElement, so this would get in the way of patching SVG element; it's also inconsistent with the return-type.

Closes #47

codecov-io commented 6 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         115    115           
  Branches       34     34           
=====================================
  Hits          115    115

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4562cf2...5383414. Read the comment docs.

jorgebucaran commented 6 years ago

Hey guys, @andrewiggins @pspeter3 @swizz, would have a look? 👋

jorgebucaran commented 6 years ago

Shall we merge? :)