jorgebucaran / superfine

Absolutely minimal view layer for building web interfaces
https://git.io/super
MIT License
1.57k stars 78 forks source link

2.0 #98

Closed dancespiele closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #98 into 2.0 will increase coverage by 1.7%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.0      #98     +/-   ##
=========================================
+ Coverage   97.43%   99.14%   +1.7%     
=========================================
  Files           1        1             
  Lines         117      117             
  Branches       36       36             
=========================================
+ Hits          114      116      +2     
+ Misses          2        0      -2     
  Partials        1        1
Impacted Files Coverage Δ
src/index.js 99.14% <0%> (+1.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b40b5d6...78674ed. Read the comment docs.

jorgebucaran commented 6 years ago

Thanks, @dancespiele. Did you take these tests from Hyperapp? Since the lifecycle events are essentially the same as in Hyperapp, I want to copy the tests from Hyperapp to avoid having to maintain two different implementations of the tests.

dancespiele commented 6 years ago

the unique thing that I changed for adapting to the new patch was beforeEach

beforeEach(() => {
  document.body.innerHTML= "";
  const el = document.createElement('div');
  element = document.body.appendChild(el);
})

the tests are the same If you find the way that the tests works with this beforeEach

beforeEach(() => {
  document.body.innerHTML = ""
})

please let me know because I couldn't

jorgebucaran commented 6 years ago

Thanks, but the tests are fixed now. 👋