jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 223 forks source link

Added support for JSON serialization of dictionary #1424

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

A bit of a selfish PR with regard to how many branches are implemented. Given the many combinations of key, value types that can be there, I'd like to have them under a feature flag.

Currently we don't do this yet in arrow2 for dtypes, but given there are many of them I believe there is merit to cherry pick them as we are not light to compile.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 91.30% and project coverage change: +0.02 :tada:

Comparison is base (d06323a) 83.63% compared to head (db53304) 83.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1424 +/- ## ========================================== + Coverage 83.63% 83.66% +0.02% ========================================== Files 374 374 Lines 40603 40626 +23 ========================================== + Hits 33959 33988 +29 + Misses 6644 6638 -6 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/io/json/write/serialize.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL2pzb24vd3JpdGUvc2VyaWFsaXplLnJz) | `92.17% <91.30%> (-0.08%)` | :arrow_down: | | [src/io/ipc/read/file.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL2lwYy9yZWFkL2ZpbGUucnM=) | `97.32% <0.00%> (+0.89%)` | :arrow_up: | | [src/array/utf8/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L3V0ZjgvbW9kLnJz) | `83.52% <0.00%> (+1.14%)` | :arrow_up: | | [src/io/ipc/read/array/boolean.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL2lwYy9yZWFkL2FycmF5L2Jvb2xlYW4ucnM=) | `98.11% <0.00%> (+5.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.