jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 223 forks source link

Made `len/len_proxy` consistent with `Offsets` #1434

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

We already renamed this in Offsets because it returned a counterintuitive len. This bit me again. ;)

This makes sure we are consistent with Offsets and OffsetsBuffer.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 68.42% and project coverage change: -0.01 :warning:

Comparison is base (db87f71) 83.76% compared to head (adf4571) 83.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1434 +/- ## ========================================== - Coverage 83.76% 83.76% -0.01% ========================================== Files 375 375 Lines 41024 41027 +3 ========================================== + Hits 34364 34366 +2 - Misses 6660 6661 +1 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/aggregate/memory.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYWdncmVnYXRlL21lbW9yeS5ycw==) | `37.50% <0.00%> (ø)` | | | [src/offset.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL29mZnNldC5ycw==) | `84.87% <40.00%> (-0.89%)` | :arrow_down: | | [src/array/binary/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2JpbmFyeS9tb2QucnM=) | `91.82% <100.00%> (+1.44%)` | :arrow_up: | | [src/array/list/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2xpc3QvbW9kLnJz) | `91.74% <100.00%> (ø)` | | | [src/array/map/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L21hcC9tb2QucnM=) | `62.13% <100.00%> (ø)` | | | [src/array/utf8/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L3V0ZjgvbW9kLnJz) | `82.37% <100.00%> (ø)` | | | [src/io/parquet/write/pages.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvd3JpdGUvcGFnZXMucnM=) | `95.84% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1434/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.