jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

Added impl_mutable_array_mut_validity macro for mutable arrays #1435

Closed Arty-Maly closed 1 year ago

Arty-Maly commented 1 year ago

I am adding set_validity, apply_validity, and with_validity to mutable binary arrays.

I am using a macro so it can be reused for other mutable arrays.

The macro for immutable arrays is called: impl_mut_validity so I tried sticking with that convention and called it impl_mutable_array_mut_validity But if there is a better name to describe this macro I will take it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 64.28% and no project coverage change.

Comparison is base (db87f71) 83.76% compared to head (fedb075) 83.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1435 +/- ## ======================================= Coverage 83.76% 83.77% ======================================= Files 375 375 Lines 41024 41038 +14 ======================================= + Hits 34364 34379 +15 + Misses 6660 6659 -1 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/binary/mutable.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2JpbmFyeS9tdXRhYmxlLnJz) | `83.08% <ø> (ø)` | | | [src/array/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L21vZC5ycw==) | `72.00% <64.28%> (-0.52%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1435/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Arty-Maly commented 1 year ago

@jorgecarleitao I seem to be not able to figure out this IPC test failure, I even reverted my changes and ran it and it still failed. Can you give me some direction to debug this?