jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 223 forks source link

Added memmap `&[u8]` as `BooleanArray` #1436

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Same a memory mapping a slice returns a PrimitiveArray with a lifetime that is tight to the slice, this adds the functionality for a BooleanArray

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.12% and project coverage change: +0.02 :tada:

Comparison is base (db87f71) 83.76% compared to head (c79e8c5) 83.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1436 +/- ## ========================================== + Coverage 83.76% 83.79% +0.02% ========================================== Files 375 375 Lines 41024 41064 +40 ========================================== + Hits 34364 34408 +44 + Misses 6660 6656 -4 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/ffi/mmap.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2ZmaS9tbWFwLnJz) | `97.45% <93.75%> (-1.40%)` | :arrow_down: | | [src/mmap/array.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL21tYXAvYXJyYXkucnM=) | `96.70% <100.00%> (+0.06%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ritchie46 commented 1 year ago

I don't understand the integration test failure. It seems unrelated.

ritchie46 commented 1 year ago

The integration test failure is unrelated.