jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

Updated multiversion and support wider registers #1440

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Currently the simd sum only used 128 bit registers via runtime detection. This adds support for all simd available targets.

Had a 4x improvement on a local compilation. Updated multiversion while at it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 :warning:

Comparison is base (7d52276) 83.79% compared to head (5e9e574) 83.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1440 +/- ## ========================================== - Coverage 83.79% 83.76% -0.04% ========================================== Files 376 376 Lines 41128 41010 -118 ========================================== - Hits 34463 34351 -112 + Misses 6665 6659 -6 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/aggregate/min\_max.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYWdncmVnYXRlL21pbl9tYXgucnM=) | `72.72% <100.00%> (-7.83%)` | :arrow_down: | | [src/compute/aggregate/sum.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYWdncmVnYXRlL3N1bS5ycw==) | `77.08% <100.00%> (-6.67%)` | :arrow_down: | | [src/compute/hash.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvaGFzaC5ycw==) | `100.00% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1440/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.