search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

Fixed `all` and `any` on empty BooleanArray #1445

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Ensure we behave the same as rust, python on empty sets.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.33 :tada:

Comparison is base (484875a) 83.11% compared to head (0063967) 83.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1445 +/- ## ========================================== + Coverage 83.11% 83.44% +0.33% ========================================== Files 369 376 +7 Lines 40187 41165 +978 ========================================== + Hits 33401 34351 +950 - Misses 6786 6814 +28 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/boolean.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYm9vbGVhbi5ycw==) | `91.81% <66.66%> (-0.78%)` | :arrow_down: | | [src/compute/boolean\_kleene.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYm9vbGVhbl9rbGVlbmUucnM=) | `72.50% <66.66%> (+4.14%)` | :arrow_up: | ... and [199 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1445/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.