search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 223 forks source link

Implemented `is_in` and `arithmetics::rem_scalar` #1450

Closed ozgrakkurt closed 1 year ago

ozgrakkurt commented 1 year ago

closes https://github.com/jorgecarleitao/arrow2/issues/263

ozgrakkurt commented 1 year ago

Hey @ritchie46, can you check if this is similar to the polars version and maybe could be used to implement that?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 61.81% and project coverage change: -0.04 :warning:

Comparison is base (73ed7c8) 83.45% compared to head (d35d9d7) 83.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1450 +/- ## ========================================== - Coverage 83.45% 83.41% -0.04% ========================================== Files 376 377 +1 Lines 41161 41216 +55 ========================================== + Hits 34350 34380 +30 - Misses 6811 6836 +25 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/arithmetics/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYXJpdGhtZXRpY3MvbW9kLnJz) | `72.17% <0.00%> (-1.94%)` | :arrow_down: | | [src/compute/is\_in.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvaXNfaW4ucnM=) | `65.38% <65.38%> (ø)` | | ... and [4 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1450/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.