Closed andy-thomason closed 1 year ago
Thank you @andy-thomason for this PR and well spotted! 🙇
Patch coverage: 85.71
% and project coverage change: -0.02
:warning:
Comparison is base (
73ed7c8
) 83.45% compared to head (5e2c52b
) 83.43%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR fixes #1453
When mmap'ing a
FixedSizeBinaryArray
, the length in bytes was miscalculated.This was only used for a check, but to avoid UB, this should be rigourous.
The problem manifested as an
OutOfSpec
error mapping zero lengthFixedSizeBinaryArray
This fix uses the
DataType
to determine the row length.