jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

Fixed capacity of mutable_utf8 #1461

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Already done by offsets, so this underflows on empty arrays and is incorrect.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (73ed7c8) 83.45% compared to head (b16c791) 83.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1461 +/- ## ========================================== - Coverage 83.45% 83.43% -0.02% ========================================== Files 376 376 Lines 41161 41161 ========================================== - Hits 34350 34344 -6 - Misses 6811 6817 +6 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1461?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/utf8/mutable\_values.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1461?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L3V0ZjgvbXV0YWJsZV92YWx1ZXMucnM=) | `80.85% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1461/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.