jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

IPC `StreamSink` Doesn't Propagate Close to the Underlying Writer #1462

Closed theadd336 closed 1 year ago

theadd336 commented 1 year ago

Hi,

I came across this issue while working with a writer that writes data to the network. When I call close on the IPC SinkStream, I discovered that the underlying writer wasn't closed, which prevented the underlying writer from flushing its data to the network and cleaning itself up.

If I'm misunderstanding how to use the SinkStream, let me know, and I can correct my usage. If this is an actual issue, I'm happy to contribute a fix PR.

Thanks!

theadd336 commented 1 year ago

I also don't seem to have the permissions to add a label, but based on the contribution guide, this label should be no-changelog