Closed alexander-beedie closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
e14c238
) 83.92% compared to head (888f780
) 83.94%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @alexander-beedie. Great fix. :+1:
The
timestamp_XX_to_datetime
functions all panic with "invalid or out-of-range datetime" on conversions of values with fractional seconds before the epoch (where the timestamp becomes negative).For these timestamps (pre-epoch, fractional secs) the
(v % <scale_factor>) as u32
formulation is not valid, asas u32
This PR allows pre-epoch conversions with fractional seconds to be handled correctly, and adds some new tests to provide the missing coverage.