jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

Added parquet deserialization of nested null types #1472

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Nested nulls were not supported. They were written, but not read.

This adds support for that.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.25 :warning:

Comparison is base (144a8b8) 83.93% compared to head (48c24de) 83.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1472 +/- ## ========================================== - Coverage 83.93% 83.68% -0.25% ========================================== Files 387 389 +2 Lines 41629 41746 +117 ========================================== - Hits 34942 34937 -5 - Misses 6687 6809 +122 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L21vZC5ycw==) | `77.65% <ø> (ø)` | | | [src/array/null.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L251bGwucnM=) | `43.87% <0.00%> (-24.38%)` | :arrow_down: | | [src/io/parquet/read/deserialize/nested.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9uZXN0ZWQucnM=) | `71.10% <0.00%> (-1.87%)` | :arrow_down: | | [src/io/parquet/read/deserialize/null/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9udWxsL21vZC5ycw==) | `95.77% <ø> (ø)` | | | [src/io/parquet/read/deserialize/null/nested.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9udWxsL25lc3RlZC5ycw==) | `0.00% <0.00%> (ø)` | | | [src/io/parquet/read/statistics/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9zdGF0aXN0aWNzL21vZC5ycw==) | `86.49% <0.00%> (-0.42%)` | :arrow_down: | | [src/io/parquet/read/statistics/null.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9zdGF0aXN0aWNzL251bGwucnM=) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1472/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.