jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

Fixed struct FFI for sliced pyarrow #1474

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

Fix ffi for sliced struct arrays coming from pyarrow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (64d8ec2) 83.68% compared to head (9f171f8) 83.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1474 +/- ## ========================================== + Coverage 83.68% 83.72% +0.04% ========================================== Files 389 389 Lines 41746 41775 +29 ========================================== + Hits 34936 34978 +42 + Misses 6810 6797 -13 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/struct\_/ffi.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L3N0cnVjdF8vZmZpLnJz) | `94.54% <100.00%> (+4.89%)` | :arrow_up: | | [src/bitmap/immutable.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2JpdG1hcC9pbW11dGFibGUucnM=) | `88.60% <100.00%> (+0.70%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://codecov.io/gh/jorgecarleitao/arrow2/pull/1474/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.